cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r325956805
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -663,7 +661,7 @@ class Analyzer(
*
* [[ResolveRelations]] still resolves v1 tables.
*/
- object ResolveTables extends Rule[LogicalPlan] {
+ object ResolveV2Relations extends Rule[LogicalPlan] {
Review comment:
This rule only resolves `UnresolvedRelation` to `DataSourceV2Relation` so I
think the new name is fine.
I need this renaming because I added a new rule `ResolveTables` which
resolves the identifier to a `Table` instance. Do you have a better idea about
how to naming these rules?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
