Github user koeninger commented on the pull request:
https://github.com/apache/spark/pull/3798#issuecomment-71968759
packaging, makes sense
method name, agreed, named it createNewStream for now
offset range, see my explanation of the interface above. I think this is
the last substantive / non-style issue to get worked out
unit tests for the stream / kafkacluster, will see what I can do
On Wed, Jan 28, 2015 at 8:49 PM, Tathagata Das <[email protected]>
wrote:
> At a high level these are the high level design issues that are still
> pending
>
> - Packaging - I think all the classes should be
> org.apache.spark.streaming.kafka (even KafkaRDD), because (i) all of
them
> are published in spark-streaming-kafka artifact, (ii) just importing
one
> path (o.a.spark.streaming.kafka.KafkaUtils._) is sufficient get all the
> relevant classes.
> - KafkaUtils method name and scala doc - Lets keep thinking of names,
> but lets not stay blocked on this and continue focussing on other
issues.
> - OffsetRange - I have proposed a design as well. Either we will go
> for Java interface or the simple class that I proposed.
> - Unit tests - No unit test for the new stream. Also is it possible to
> include a few unit tests for KafkaCluster?
>
> Other than these, I will start commenting on the code styles, etc very
> soon.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3798#issuecomment-71960076>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
