HyukjinKwon edited a comment on issue #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#issuecomment-533862934 While it looks good in general, let me leave some comments per my review just for recording purpose. https://github.com/apache/spark/pull/24981#discussion_r326890317 this comment at least seems critical - let me make a quick followup. If tests cannot pass, technically we might have to revert this PR. For clarification, I have no objection for the fact it was merged.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
