HyukjinKwon edited a comment on issue #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#issuecomment-534037873 @d80tb7, can you address other comments except refactoring `BasePandasGroupExec` and `BaseArrowPythonRunner`? Let me take a closer look and see if we can avoid to introduce some hierarchy if you don't mind. ~~From a cursory look, I think we can just put those methods in companion objects and reuse it.~~ I got it why you did like this. Let me take a closer look before I ask something. If that sounds fine to you and @BryanCutler in general, let me open a PR instead to deal with refactoring stuff in a separate JIRA ticket. BTW, I am now doing reserve force training 3 more days from now one (yes, in Korea we need to do it for some days as mandatory :D) so my progress might be a bit slow.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
