Github user jacek-lewandowski commented on the pull request:

    https://github.com/apache/spark/pull/4220#issuecomment-71992373
  
    It looks like there is `ResetSystemProperties` trait which works completely 
wrong. Its aim is to save system properties before the test and the reset them 
after the test. However, the way the copy was created and then restored was 
invalid. 
    
    The copy was created in this way:
    ```scala
    oldProperties = new Properties(System.getProperties)
    ```
    
    which did not initialize properties as they were in the original system 
properties but rather set them as defaults in new properties object, which in 
turn made `JPropertiesWrapper` not consider them at all (actually 
JPropertiesWrapper would return empty iterator then).
    
    The way I'm gonna fix `ResetSystemProperties` class is to use 
`SerializationUtils.clone` to save the system properties.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to