Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4220#discussion_r23776203
--- Diff:
core/src/test/scala/org/apache/spark/util/ResetSystemProperties.scala ---
@@ -42,7 +43,7 @@ private[spark] trait ResetSystemProperties extends
BeforeAndAfterEach { this: Su
var oldProperties: Properties = null
override def beforeEach(): Unit = {
- oldProperties = new Properties(System.getProperties)
+ oldProperties = SerializationUtils.clone(System.getProperties)
--- End diff --
thanks for tracking this down. can you please put a comment in here
explaining why you need a clone? it is really subtle, I can easily see this
getting reverted down the road if somebody doesn't know why its there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
