Github user nchammas commented on the pull request:

    https://github.com/apache/spark/pull/4162#issuecomment-72088000
  
    OK, I think we're almost there. One final suggestion I'd make it to move 
these checks on the identity file to the [input parameter validation 
area](https://github.com/Liuchang0812/spark/blob/ec2-script/ec2/spark_ec2.py#L1006),
 since they also apply when people are logging into a cluster.
    
    So  basically, if the `identity_file` option is specified, we check upfront 
that it exists and has the right permissions. Then, no matter where its used -- 
launching, logging in, or other -- we know that it is valid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to