Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796642
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -321,6 +321,12 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case CreateTableUsing(tableName, userSpecifiedSchema, provider,
false, options) =>
sys.error("Tables created with SQLContext must be TEMPORARY. Use a
HiveContext instead.")
+ case DropTable(table, isExists, temporary) =>
+ if (!temporary) {
+ sys.error("Tables dropped with SQLContext must be TEMPORARY, Use
a HiveContext instead.")
+ }
+ ExecutedCommand(DropTempTable(table, isExists, temporary)) :: Nil
+
--- End diff --
Actually, you don't need `DropTable` or this `case` branch. I'd suggesting:
1. moving the `if` into `DropTempTable`,
1. removing `DropTable`
1. replacing `DropTable` in the SQL parser with `DropTempTable`
1. renaming `DropTempTable` to `DropTable`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
