Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23841357
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
}
}
+private[sql] case class DropTable(
+ tableName: String,
+ isExists: Boolean,
+ temporary: Boolean) extends Command
--- End diff --
hi, @liancheng, I think we do need this logical `DropTable`.
Since all parser should go first ddlParser, if not get plan, then it will
try dialect parser.
If I remove this `logical drop table`, when execute `drop table xxx`, it
will always use `DropTableCommand` in `SQLContext`. Sorry if I'm wrong.
In HiveContext.
>>
else if (conf.dialect == "hiveql") {
new SchemaRDD(this, ddlParser(sqlText,
false).getOrElse(HiveQl.parseSql(substituted)))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
