maropu commented on a change in pull request #25913: [WIP][SPARK-29221][SQL] 
LocalTableScanExec: handle the case where executors are accessing "null" rows
URL: https://github.com/apache/spark/pull/25913#discussion_r327867726
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
 ##########
 @@ -37,7 +37,7 @@ case class LocalTableScanExec(
     "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output 
rows"))
 
   @transient private lazy val unsafeRows: Array[InternalRow] = {
-    if (rows.isEmpty) {
+    if (rows == null || rows.isEmpty) {
 
 Review comment:
   Ah, I see. I'm a bit worried that this value could be different between a 
driver and executors. Which code touches this variable in executors? What's the 
stacktrace for `unsafeRows`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to