maropu commented on a change in pull request #25913: [WIP][SPARK-29221][SQL]
LocalTableScanExec: handle the case where executors are accessing "null" rows
URL: https://github.com/apache/spark/pull/25913#discussion_r327884225
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
##########
@@ -37,7 +37,7 @@ case class LocalTableScanExec(
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
@transient private lazy val unsafeRows: Array[InternalRow] = {
- if (rows.isEmpty) {
+ if (rows == null || rows.isEmpty) {
Review comment:
I personally think `unsafeRows` is not expected to be called in executor
sides, so we need to check `assert(rows != null)` instead of the current
approach. If it fails then, we need to fix some code not to call this variable
in executors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
