advancedxy commented on a change in pull request #25863:
[WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give
duplicate result.
URL: https://github.com/apache/spark/pull/25863#discussion_r327984518
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -147,18 +151,29 @@ object FileCommitProtocol extends Logging {
className: String,
jobId: String,
outputPath: String,
- dynamicPartitionOverwrite: Boolean = false): FileCommitProtocol = {
+ dynamicPartitionOverwrite: Boolean = false,
+ isInsertIntoHadoopFsRelation: Boolean = false,
+ isOverwrite: Boolean = false,
+ staticPartitionKVs: Seq[(String, String)] = Seq.empty[(String, String)]):
Review comment:
I think we may need a FileSourceWriteDesc class here to escape the added
parameters here.
And to be compatible with old versions, a new method signature should be
added.
WDYT @cloud-fan and @turboFei ?
Also , the comment in the class doc should be updated correspondingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
