advancedxy commented on a change in pull request #25863: 
[WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give 
duplicate result.
URL: https://github.com/apache/spark/pull/25863#discussion_r327987102
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
 ##########
 @@ -271,4 +318,59 @@ class HadoopMapReduceCommitProtocol(
         logWarning(s"Exception while aborting 
${taskContext.getTaskAttemptID}", e)
     }
   }
+
+  /**
+   * Delete the staging output path of current InsertIntoHadoopFsRelation 
operation.
 
 Review comment:
   This doc needs more detailed comments. Explain how we deleting staging dir 
and why we do that way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to