rdblue commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r328287799
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -599,11 +596,9 @@ case class DropTable(
case class AlterTable(
catalog: TableCatalog,
ident: Identifier,
- table: NamedRelation,
+ table: Table,
Review comment:
As I think about this more, it seems like a bad idea.
This ties the SQL logical plans to a particular type of relation. There is
no need to do that. What if we decide to add a v3 connector API? Then we would
have to change all of these logical plans instead of using a new type of
relation.
I think we should move this back to `NamedRelation` to keep logical plans
and the connector API separate. That also makes rules cleaner, because catalog
resolution and table resolution are done in independent rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
