rdblue commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r328843491
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -253,7 +253,7 @@ private[sql] final case class LiteralValue[T](value: T,
dataType: DataType) exte
}
private[sql] final case class FieldReference(parts: Seq[String]) extends
NamedReference {
- import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
+ import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultiPartIdentifierHelper
Review comment:
I wouldn't say it's a typo. The word "multipart" without a space or a hyphen
is by far [the most used spelling of
multipart](https://books.google.com/ngrams/graph?content=multipart%2Cmulti-part%2Cmulti+part&year_start=1800&year_end=2000&corpus=15&smoothing=3&share=&direct_url=t1%3B%2Cmultipart%3B%2Cc0%3B.t1%3B%2Cmulti%20-%20part%3B%2Cc0%3B.t1%3B%2Cmulti%20part%3B%2Cc0#t1%3B%2Cmultipart%3B%2Cc0%3B.t1%3B%2Cmulti%20-%20part%3B%2Cc0%3B.t1%3B%2Cmulti%20part%3B%2Cc0).
I think this should be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
