vanzin commented on a change in pull request #25823:
[SPARK-28211][Core][Shuffle] Propose Shuffle Driver Components API
URL: https://github.com/apache/spark/pull/25823#discussion_r328690367
##########
File path: core/src/main/java/org/apache/spark/shuffle/api/ShuffleDataIO.java
##########
@@ -41,9 +41,20 @@
@Private
public interface ShuffleDataIO {
+ /**
+ * The prefix of spark config keys that are passed from the driver to the
executor.
+ */
+ String SHUFFLE_SPARK_CONF_PREFIX = "spark.shuffle.plugin.";
Review comment:
Does this need to be public? It's only used internally. Not sure of the best
place to place this, but a public interface isn't it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
