vanzin commented on a change in pull request #25823:
[SPARK-28211][Core][Shuffle] Propose Shuffle Driver Components API
URL: https://github.com/apache/spark/pull/25823#discussion_r328699841
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -524,6 +528,19 @@ class SparkContext(config: SparkConf) extends Logging {
executorEnvs ++= _conf.getExecutorEnv
executorEnvs("SPARK_USER") = sparkUser
+ val configuredPluginClasses = conf.get(SHUFFLE_IO_PLUGIN_CLASS)
+ val maybeIO = Utils.loadExtensions(
+ classOf[ShuffleDataIO], Seq(configuredPluginClasses), conf)
+ require(maybeIO.nonEmpty, s"At least one valid shuffle plugin must be
specified by config " +
+ s"${SHUFFLE_IO_PLUGIN_CLASS.key}, but $configuredPluginClasses resulted
in zero valid " +
+ s"plugins.")
+ require(maybeIO.size == 1,
Review comment:
This is unnecessary, because the config is a single string (as you can see
when you call `loadExtensions` with `Seq(configuredPluginClasses)`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
