rdblue commented on a change in pull request #25747: [SPARK-29039][SQL] 
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r328844352
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ##########
 @@ -619,11 +616,9 @@ case class DropTable(
 case class AlterTable(
     catalog: TableCatalog,
 
 Review comment:
   Right, but at least it keeps the read/write API separated. The catalog API 
and the read/write API are orthogonal to one another. We can replace the 
read/write API without replacing the catalog API, so no need to tie logical 
plans to the read/write API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to