cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL]
Implement USE CATALOG/NAMESPACE for Data Source V2
URL: https://github.com/apache/spark/pull/25771#discussion_r328958608
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -166,13 +169,14 @@ abstract class BaseSessionStateBuilder(
*
* Note: this depends on the `conf` and `catalog` fields.
*/
- protected def analyzer: Analyzer = new Analyzer(catalog, v2SessionCatalog,
conf) {
- override val extendedResolutionRules: Seq[Rule[LogicalPlan]] =
- new FindDataSourceTable(session) +:
- new ResolveSQLOnFile(session) +:
- new FallBackFileSourceV2(session) +:
- DataSourceResolution(conf, this.catalogManager) +:
- customResolutionRules
+ protected def analyzer: Analyzer =
+ new Analyzer(catalogManager, conf) {
Review comment:
super nit: we can keep the indentation unchanged? i.e. still put the `new
Analyzer` in the above line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
