cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#discussion_r328959278
########## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ########## @@ -830,6 +830,70 @@ class DataSourceV2SQLSuite assert(df.collect().map(_.getAs[String](0)).sorted === expected.sorted) } + test("UseCatalog: use catalog with v2 catalog") { + val catalogManager = spark.sessionState.catalogManager + assert(catalogManager.currentCatalog.name() == "session") + + sql("USE CATALOG testcat") + assert(catalogManager.currentCatalog.name() == "testcat") + } + + test("UseCatalog: v2 catalog does not exist") { + val exception = intercept[AnalysisException] { + sql("USE CATALOG unknown") + } + assert(exception.getMessage.contains("v2 catalog 'unknown' cannot be loaded")) + } + + test("Use: basic tests with USE statements") { + val catalogManager = spark.sessionState.catalogManager + + // Validate the initial current catalog and namespace. + assert(catalogManager.currentCatalog.name() == "session") + assert(catalogManager.currentNamespace === Array("default")) + + // The following implicitly creates namespaces. Review comment: this reminds that we should have a `CREATE NAMESPACE` command. We can do it in followup. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org