vanzin commented on a change in pull request #25648: [SPARK-28947][K8S] Status
logging not happens at an interval for liveness
URL: https://github.com/apache/spark/pull/25648#discussion_r329205712
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesTestConf.scala
##########
@@ -35,7 +35,7 @@ object KubernetesTestConf {
val RESOURCE_PREFIX = "prefix"
val EXECUTOR_ID = "1"
- private val DEFAULT_CONF = new SparkConf(false)
+ private val DEFAULT_CONF = new SparkConf(false).set(WAIT_FOR_APP_COMPLETION,
false)
Review comment:
Is this for reducing the amount of logging?
If so, isn't this a bit dangerous? Because this option doesn't really
control logging, but whether to wait for the app. If there's too much log noise
you could set the report interval to a really large value.
Maybe that doesn't matter for unit tests, but it feels a bit odd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
