vanzin commented on a change in pull request #25648: [SPARK-28947][K8S] Status
logging not happens at an interval for liveness
URL: https://github.com/apache/spark/pull/25648#discussion_r329669108
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala
##########
@@ -177,13 +176,13 @@ class ClientSuite extends SparkFunSuite with
BeforeAndAfter {
}
test("Waiting for app completion should stall on the watcher") {
+ kconf.sparkConf.set(WAIT_FOR_APP_COMPLETION, true)
Review comment:
Sorry, not following. The only code that "stalls" is
`LoggingPodStatusWatcherImpl`, and this test is using a mock, not that
implementation. So what exactly is using this config?
BTW that question applies to all changes you're making in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
