squito commented on a change in pull request #25779: [SPARK-27468][core] Track
correct storage level and mem/disk usage for RDDs.
URL: https://github.com/apache/spark/pull/25779#discussion_r329224584
##########
File path:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala
##########
@@ -763,6 +769,7 @@ class AppStatusListenerSuite extends SparkFunSuite with
BeforeAndAfter {
assert(part.memoryUsed === rdd1b1.memSize * 2)
Review comment:
unrelated to your change, but for the line just above
(`wrapper.info.partitions.get(0)`), would it be better to have
`wrapper.info.partitions.get.find(_.blockName == rddb1.blockId.name)` ? Or at
least an assert after that, that you have the right block? otherwise will lead
to confusing errors later if somebody changes the test and the rdd1b1 isn't
added first.
Also unrelated to your change, but coming back to this code after a long
time I was a little surprised that `info.partitions` isn't ordered by the
partition, that may also be worth a comment somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
