yaooqinn commented on a change in pull request #25648: [SPARK-28947][K8S]
Status logging not happens at an interval for liveness
URL: https://github.com/apache/spark/pull/25648#discussion_r329290356
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesTestConf.scala
##########
@@ -35,7 +35,7 @@ object KubernetesTestConf {
val RESOURCE_PREFIX = "prefix"
val EXECUTOR_ID = "1"
- private val DEFAULT_CONF = new SparkConf(false)
+ private val DEFAULT_CONF = new SparkConf(false).set(WAIT_FOR_APP_COMPLETION,
false)
Review comment:
https://github.com/apache/spark/blob/7912ab85a6fc086b814d93e7c71af1f50515517a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala#L205
As the `spark.kubernetes.report.interval` is always positive, I guess if
WAIT_FOR_APP_COMPLETION is true, the logging is inevitably on whether in a long
or short interval.
I don't think this is dangerous, because in fact this only controls the
logic of LoggingPodStatusWatcher before or after this change.
For unit tests, this will only take effect in `k8s.submit.ClientSuite`, if
it feels a bit odd to you, I can set this test by test in that test class
also cc @erikerlandson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
