zero323 commented on issue #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#issuecomment-536177483 @srowen @zhengruifeng @huaxingao Could you explain the rationale behind 425959e? Leading underscore doesn't really have the same semantics as Scala package private (or private modifier in general). However, when used in context which have direct impact on user facing API, it is quite annoying, as it requires manually segregation from truly internal components. Even if the goal is simple API parity it makes sense to take such things into account. Otherwise the whole thing could be just code generated. Just saying...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
