zero323 commented on issue #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#issuecomment-536205860 > If the general question is, why hide things? just the usual software design idea, to only expose what you intend to support as a user or developer API. I'm not making a specific judgment about whether these should be exposed or not, just don't know yet. Not at all @srowen. It is a specific question. These mixins are used only to augment public API, and as such directly affect user's code (for example method resolution order), so it is a bit fuzzy why indicate them as internal. From one hand their usage is limited to specific `Estimator` / `Model` pair, so there is really little value in exposing these to the end user. From the other, hand limited scope suggests little potential for change, especially one that doesn't affect public API, hence there seems to be no little harm in exposing these (the problem is similar to [SPARK-7146](https://issues.apache.org/jira/browse/SPARK-7146)). In contrast to [SPARK-29212](https://issues.apache.org/jira/browse/SPARK-29212), I am indifferent here and just trying to get a better feeling how the API evolves and what drives certain decisions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
