attilapiros commented on a change in pull request #25779: [SPARK-27468][core]
Track correct storage level and mem/disk usage for RDDs.
URL: https://github.com/apache/spark/pull/25779#discussion_r329674609
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -235,13 +230,14 @@ private[spark] class AppStatusListener(
rdd.diskUsed = addDeltaToValue(rdd.diskUsed,
(partition.diskUsed / partition.executors.length) * -1)
partition.update(partition.executors
- .filter(!_.equals(event.executorId)), rdd.storageLevel,
+ .filter(!_.equals(event.executorId)),
addDeltaToValue(partition.memoryUsed,
(partition.memoryUsed / partition.executors.length) * -1),
addDeltaToValue(partition.diskUsed,
(partition.diskUsed / partition.executors.length) * -1))
}
}
+ }
update(rdd, now)
Review comment:
I guess the `update` in this line was unnecessary?
https://github.com/apache/spark/blob/4c8f114783241e780c0ad227bfb3191657637df7/core/src/main/scala/org/apache/spark/status/AppStatusListener.scala#L219-L221
I think this is the `update` which caused the confusion for @squito too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
