attilapiros commented on a change in pull request #25779: [SPARK-27468][core]
Track correct storage level and mem/disk usage for RDDs.
URL: https://github.com/apache/spark/pull/25779#discussion_r329756937
##########
File path:
core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala
##########
@@ -800,9 +807,27 @@ class AppStatusListenerSuite extends SparkFunSuite with
BeforeAndAfter {
assert(exec.info.diskUsed === rdd1b1.diskSize + rdd1b2.diskSize)
}
+ // Evict block 1 from memory in bm 1.
+ listener.onBlockUpdated(SparkListenerBlockUpdated(
+ BlockUpdatedInfo(bm1, rdd1b1.blockId, StorageLevel.DISK_ONLY, 0L,
rdd1b1.diskSize)))
+
+ check[RDDStorageInfoWrapper](rdd1b1.rddId) { wrapper =>
+ assert(wrapper.info.numCachedPartitions === 2L)
+ assert(wrapper.info.memoryUsed === rdd1b1.memSize + rdd1b2.memSize)
+ assert(wrapper.info.diskUsed === 2 * rdd1b1.diskSize + rdd1b2.diskSize)
+ assert(wrapper.info.dataDistribution.get.size === 2L)
+ assert(wrapper.info.partitions.get.size === 2L)
+ }
+
+ check[ExecutorSummaryWrapper](bm1.executorId) { exec =>
+ assert(exec.info.rddBlocks === 2L)
+ assert(exec.info.memoryUsed === rdd1b2.memSize)
+ assert(exec.info.diskUsed === rdd1b1.diskSize + rdd1b2.diskSize)
+ }
+
// Remove block 1 from bm 1.
listener.onBlockUpdated(SparkListenerBlockUpdated(
- BlockUpdatedInfo(bm1, rdd1b1.blockId, StorageLevel.NONE, rdd1b1.memSize,
rdd1b1.diskSize)))
+ BlockUpdatedInfo(bm1, rdd1b1.blockId, StorageLevel.NONE, 0L, 0L)))
Review comment:
This was I assume a mistake in the test as the delta was reported here and
not the currently used mem and disk size. This is why this line is changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
