Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/3637#issuecomment-72289848
@jkbradley Apologies for the delay in reviewing this. I think this is
looking pretty good and just had some minor comments inline.
One high-level question I had was whether we are planning a follow up PR
which will give strong types in the protected API for `train` i.e. `train(data:
RDD[LabeledPoint])`. The design doc says this can be added later "once
ML-related metadata is easily extractable from a SchemaRDD" and I just wanted
to check on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
