vanzin commented on a change in pull request #25823:
[SPARK-28211][Core][Shuffle] Propose Shuffle Driver Components API
URL: https://github.com/apache/spark/pull/25823#discussion_r331283442
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -524,6 +529,15 @@ class SparkContext(config: SparkConf) extends Logging {
executorEnvs ++= _conf.getExecutorEnv
executorEnvs("SPARK_USER") = sparkUser
+ _shuffleDriverComponents =
ShuffleDataIOUtils.loadShuffleDataIO(config).driver()
+ _shuffleDriverComponents.initializeApplication().asScala.foreach { case
(k, v) =>
+ val key = ShuffleDataIOUtils.SHUFFLE_SPARK_CONF_PREFIX + k
+ if (_conf.contains(key)) {
Review comment:
My suggestion is to not even bother with trying to detect anything. Write
the configs from the driver plugin, read everything on the executor side, don't
warn about anything.
This should be considered an internal namespace (which is why I suggested
that prefix) and users shouldn't mess with it. If they do, and they run into
problems, it's their problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
