HeartSaVioR commented on a change in pull request #25670: [SPARK-28869][CORE]
Roll over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r331326938
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1165,12 +1161,15 @@ private[history] case class LogInfo(
logType: LogType.Value,
appId: Option[String],
attemptId: Option[String],
- fileSize: Long)
+ fileSize: Long,
+ lastIndex: Option[Long],
Review comment:
Just realized that FsHistoryProvider does some care on `logType` being
`null`. I wouldn't expect LogType.Value is null and feel safer to correct the
value, but given now FsHistoryProvider accesses logType correctly, that's OK.
I'd prefer to add UT to check the values of field of LogInfo when reading from
Spark 2.4.4 to make sure we're not missing anything, but it's just me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
