HeartSaVioR commented on a change in pull request #25670: [SPARK-28869][CORE]
Roll over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r331724862
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1165,12 +1161,15 @@ private[history] case class LogInfo(
logType: LogType.Value,
appId: Option[String],
attemptId: Option[String],
- fileSize: Long)
+ fileSize: Long,
+ lastIndex: Option[Long],
Review comment:
Good point. In other tests which we have modified something and worried
about compatibility, we stored the old data and load from there so I thought
about the same. Your suggestion would be pretty much simpler. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
