Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4220#issuecomment-72306613
I did a little digging and it looks like this
ConcurrentModificationException error was fixed previously
(8f1098a3f0de8c9b2eb9ede91a1b01da10a525ea) but that the fix may have been lost
as part of the migration to SparkConf. It looks like #3788 addressed a similar
issue for another usage of System.getProperties. For uniformity's sake, what
do you think about using `Utils.getSystemProperties` here instead of
`stringProperties`?
Thanks for adding the regression test.
The bug in ResetSystemProperties was a silly mistake on my part, which was
introduced in https://issues.apache.org/jira/browse/SPARK-1010; thanks for
fixing that.
If / when you update this PR, mind adding a one- or two-sentence
description that will become the commit message?
Once we've done that and decided whether to use
`Utils.getSystemProperties`, let's merge this into master and all of the
maintenance branches to fix the test issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
