Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/4220#issuecomment-72308249
`Utils.getSystemProperties` is fine but not as a replacement of
`stringProperties`. There were actually two problems - one was related to
`ConcurrentModificationException` and the other one was related to abandoning
completely the defaults. Unfortunately `Utils.getSystemProperties` is not
enough because it doesn't make Scala wrapper over Java properties (which is
used when you just iterate over them) to consider default values defined for
the properties (as I said - they make a hierarchy). Since you still need to use
`stringPropertyNames` which creates a defensive copy anyway, cloning properties
before you want to use them seems to be redundant. Maybe a more clear solution
would be to modify `Utils.getSystemProperties` to use `stringPropertyNames` to
make a copy and return just a simple `Map` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
