AngersZhuuuu commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539274855 > 2. New dependencies like org.apache.hive:hive-beeline etc need to be listed in LICENSE-binary Have done this and checked other changes. > 3. This is a little annoying, but I'd check the new Hive dependencies for a NOTICE file in each and add them to NOTICE-binary where they don't already exist, along with the existing Hive NOTICE entries. I will check this today > 4. I think we need to add a line for velocity in `LICENSE-binary`? It's already in `NOTICE-binary`, so not sure what happened to the former entry Not very clear what you mean.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
