xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core]
Optimize shuffle fetch of continuous partition IDs
URL: https://github.com/apache/spark/pull/26040#discussion_r332473695
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
##########
@@ -165,21 +165,34 @@ public void registerExecutor(
}
/**
- * Obtains a FileSegmentManagedBuffer from (shuffleId, mapId, reduceId). We
make assumptions
- * about how the hash and sort based shuffles store their data.
+ * Obtains a FileSegmentManagedBuffer from a single block (shuffleId, mapId,
reduceId).
*/
public ManagedBuffer getBlockData(
String appId,
String execId,
int shuffleId,
long mapId,
int reduceId) {
+ return getBlocksData(appId, execId, shuffleId, mapId, reduceId, reduceId +
1);
+ }
+
+ /**
+ * Obtains a FileSegmentManagedBuffer from (shuffleId, mapId,
[startReduceId, endReduceId)).
+ * We make assumptions about how the hash and sort based shuffles store
their data.
+ */
+ public ManagedBuffer getBlocksData(
Review comment:
Rename to `getContinuousBlockData` in 407b1e0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
