xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] 
Optimize shuffle fetch of continuous partition IDs
URL: https://github.com/apache/spark/pull/26040#discussion_r332858356
 
 

 ##########
 File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
 ##########
 @@ -103,7 +103,11 @@ protected void handleMessage(
           checkAuth(client, msg.appId);
           numBlockIds = 0;
           for (int[] ids: msg.reduceIds) {
-            numBlockIds += ids.length;
+            if (msg.batchFetchEnabled) {
 
 Review comment:
   Copy, also simplified the code in NettyBlockRpcService.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to