Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4294#discussion_r23892984
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -145,6 +145,11 @@ abstract class PrunedFilteredScan extends BaseRelation 
{
      * for experimentation.
      */
     @Experimental
    -abstract class CatalystScan extends BaseRelation {
    +trait CatalystScan extends BaseRelation {
       def buildScan(requiredColumns: Seq[Attribute], filters: 
Seq[Expression]): RDD[Row]
     }
    +
    +@DeveloperApi
    +trait InsertableRelation extends BaseRelation {
    +  def insertInto(data: DataFrame, overwrite: Boolean): Unit
    --- End diff --
    
    The method name looks a bit weird when you put them together: 
`relation.insertInto(dataFrame)`, seems that we are inserting a relation into a 
data frame... Maybe just `insert`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to