Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4294#discussion_r23913396
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -334,6 +335,71 @@ class SQLContext(@transient val sparkContext: 
SparkContext)
         applySchema(rowRDD, appliedSchema)
       }
     
    +  @Experimental
    +  def load(
    +    dataSourceName: String,
    +    options: Map[String, String]): DataFrame = {
    +    val resolved = ResolvedDataSource(this, None, dataSourceName, options)
    +    new DataFrame(this, LogicalRelation(resolved.relation))
    +  }
    +
    +  @Experimental
    +  def load(
    +    dataSourceName: String,
    +    options: java.util.Map[String, String]): DataFrame = {
    +    load(dataSourceName, options.toMap)
    +  }
    +
    +  @Experimental
    +  def loadAsTempTable(
    --- End diff --
    
    btw the style convention is 4 space indent for function parameter 
defintion, i.e.
    
    ```scala
    def loadAsTempTable(
        tableName: String,
        dataSourceName: String,
        options: Map[String, String]): Unit = {
      val cmd = ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to