Ngone51 commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r333598202
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -103,6 +104,81 @@ private[spark] class AppStatusListener(
}
}
+ // visible for tests
+ private[spark] def recoverLiveEntities(): Unit = {
+ if (!live) {
+ kvstore.view(classOf[JobDataWrapper])
+ .asScala.filter(_.info.status == JobExecutionStatus.RUNNING)
+ .map(_.toLiveJob).foreach(job => liveJobs.put(job.jobId, job))
+
+ kvstore.view(classOf[StageDataWrapper]).asScala
+ .filter { stageData =>
+ stageData.info.status == v1.StageStatus.PENDING ||
+ stageData.info.status == v1.StageStatus.ACTIVE
+ }
+ .map { stageData =>
+ val stageId = stageData.info.stageId
+ val jobs = liveJobs.values.filter(_.stageIds.contains(stageId)).toSeq
+ stageData.toLiveStage(jobs)
+ }.foreach { stage =>
+ val stageId = stage.info.stageId
+ val stageAttempt = stage.info.attemptNumber()
+ liveStages.put((stageId, stageAttempt), stage)
Review comment:
Yeah. But for now, I'd prefer to use Tuple2 (stageId, stageAttempt) as
`AppStatusListener` already do. And we could leave such optimization in a
separate PR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
