sandeep-katta commented on a change in pull request #25977: 
[SPARK-29268][SQL]isolationOn value is wrong in case of 
spark.sql.hive.metastore.jars != builtin
URL: https://github.com/apache/spark/pull/25977#discussion_r333926916
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
 ##########
 @@ -414,7 +415,7 @@ private[spark] object HiveUtils extends Logging {
         hadoopConf = hadoopConf,
         execJars = jars.toSeq,
         config = configurations,
-        isolationOn = true,
+        isolationOn = !isCliSessionState(),
 
 Review comment:
   there are 2 approach
   
   1.based on `isCliSessionState`  Hive class should be loaded ( This PR fix)
   2. Throw exception at the start of spark-sql if user used !builtin. By doing 
this there might be a problem, because currently this problem exists for Derby, 
if the user uses some other Database there will be a impact

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to