Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4014#discussion_r23904386
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim12.scala ---
@@ -241,8 +241,14 @@ private[hive] object HiveShim {
Decimal(hdoi.getPrimitiveJavaObject(data).bigDecimalValue())
}
}
+
+ implicit def prepareWritable(shimW: ShimWritable): Writable = {
+ shimW.writable
+ }
}
+case class ShimWritable(writable: Writable)
--- End diff --
Why do we need `ShimWriteable`? Couldn't the `prepareWriteable` function
just take a `Writeable`? Furthermore, does it break Hive 12 if we just always
fix avro writeable? It would be good to minimize the size of the shim when
possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
