cloud-fan commented on a change in pull request #26095:
[SPARK-29435][Core]Shuffle is not working when
spark.shuffle.useOldFetchProtocol=true
URL: https://github.com/apache/spark/pull/26095#discussion_r334322988
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala
##########
@@ -47,8 +47,7 @@ private[spark] class BlockStoreShuffleReader[K, C](
context,
blockManager.blockStoreClient,
blockManager,
- mapOutputTracker.getMapSizesByExecutorId(handle.shuffleId,
startPartition, endPartition,
- SparkEnv.get.conf.get(config.SHUFFLE_USE_OLD_FETCH_PROTOCOL)),
+ mapOutputTracker.getMapSizesByExecutorId(handle.shuffleId,
startPartition, endPartition),
Review comment:
This is the shuffle read side and we need to know the value of
`SHUFFLE_USE_OLD_FETCH_PROTOCOL`. I think the bug is in the shuffle write side
which is fixed in this PR. Do we really need to change the shuffle read side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
