cloud-fan commented on a change in pull request #26095:
[SPARK-29435][Core]Shuffle is not working when
spark.shuffle.useOldFetchProtocol=true
URL: https://github.com/apache/spark/pull/26095#discussion_r334388365
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -905,15 +900,8 @@ private[spark] object MapOutputTracker extends Logging {
for (part <- startPartition until endPartition) {
val size = status.getSizeForBlock(part)
if (size != 0) {
- if (useOldFetchProtocol) {
- // While we use the old shuffle fetch protocol, we use mapIndex
as mapId in the
- // ShuffleBlockId.
- splitsByAddress.getOrElseUpdate(status.location, ListBuffer()) +=
- ((ShuffleBlockId(shuffleId, mapIndex, part), size, mapIndex))
- } else {
- splitsByAddress.getOrElseUpdate(status.location, ListBuffer()) +=
- ((ShuffleBlockId(shuffleId, status.mapTaskId, part), size,
mapIndex))
- }
+ splitsByAddress.getOrElseUpdate(status.location, ListBuffer()) +=
+ ((ShuffleBlockId(shuffleId, status.mapTaskId, part), size,
mapIndex))
Review comment:
OK I get it now. We should rename `MapStatus.mapTaskId` to `mapId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
