MaxGekk commented on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds URL: https://github.com/apache/spark/pull/26134#issuecomment-542653695 Since SQL has always determined zone offsets, a day has 24 hours always, and interval hours are in `0..23`: <img width="422" alt="Screen Shot 2019-10-16 at 13 48 43" src="https://user-images.githubusercontent.com/1580697/66912682-b4d2ae00-f01b-11e9-98d1-fad089969fbf.png";> Current implementation of `CalendarIntervalType` is correct union of SQL year-month INTERVAL and day-time INTERVAL. Also there is no issue of adding intervals to timestamps on Daylight saving day if we assume that the time part of intervals is just "logical" adjustment. Taking into account that local hours of timestamps are always in the range of `[0, 23]`, @LinhongLiu could you show concrete example when old (current) implementation returns wrong results, and your changes fix that. And it would be nice to put such example in the description of this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1580697/66912682-b4d2ae00-f01b-11e9-98d1-fad089969fbf.png"](https://user-images.githubusercontent.com/1580697/66912682-b4d2ae00-f01b-11e9-98d1-fad089969fbf.png"){kind=link}