MaxGekk commented on issue #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds URL: https://github.com/apache/spark/pull/26134#issuecomment-542769930 > the first case is adding 1 day on 2019-11-02 12:00:00 PST in current code will result in 2019-11-03 11:00:00 PST ok. Your PR changes this behavior. Not sure what users want to see - the timestamp after exactly 24 hours or 25 hours. Also it is debatable that it is worth to consume 30% more memory for this. > the second case is in SS, if we do a window agg like this: > df.groupBy(window($"time", "1 day")).sum This is actually behavior change, and users will struggle trouble shooting such difference in results, I think. When they usually summarize over 24 hours, but sometimes over 23 or 25 hours after your changes. Not sure that it will be expected behavior.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
