imback82 commented on a change in pull request #26120: [SPARK-29014][SQL]
DataSourceV2: Fix current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#discussion_r335684841
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -108,7 +88,7 @@ private[sql] trait LookupCatalog extends Logging {
*/
object AsTableIdentifier {
def unapply(parts: Seq[String]): Option[TableIdentifier] = parts match {
- case CatalogAndIdentifier(None, names) if defaultCatalog.isEmpty =>
+ case CatalogAndIdentifier(None, names) if
CatalogV2Util.isSessionCatalog(currentCatalog) =>
Review comment:
Same question here. Is this incorrect if the current catalog is a custom v2
session catalog since this is called for the legacy table identifier? (although
I don't think the existing logic is any better :)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
