imback82 commented on a change in pull request #26120: [SPARK-29014][SQL]
DataSourceV2: Fix current/default catalog usage
URL: https://github.com/apache/spark/pull/26120#discussion_r335682742
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -122,24 +129,24 @@ object AnalysisContext {
*/
class Analyzer(
override val catalogManager: CatalogManager,
+ v1SessionCatalog: SessionCatalog,
Review comment:
One downside of this approach (passing `SessionCatalog` as a separate
parameter) is that a `SessionCatalog` instance can be different from the one
stored in `CatalogManager`. Since `CatlalogManager` updates the current
database of the session catalog, it can be out of sync. Please let me know if
this approach is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
