rdblue commented on a change in pull request #25955: [SPARK-29277][SQL] Add
early DSv2 filter and projection pushdown
URL: https://github.com/apache/spark/pull/25955#discussion_r336274189
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -672,19 +672,23 @@ class Analyzer(
*/
object ResolveTables extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp {
- case u: UnresolvedRelation =>
- lookupV2Relation(u.multipartIdentifier)
- .getOrElse(u)
+ case u: UnresolvedV2Relation =>
+ CatalogV2Util.loadRelation(u.catalog, u.tableName).getOrElse(u)
- case i @ InsertIntoStatement(u: UnresolvedRelation, _, _, _, _) if
i.query.resolved =>
- lookupV2Relation(u.multipartIdentifier)
+ case i @ InsertIntoStatement(u: UnresolvedV2Relation, _, _, _, _) if
i.query.resolved =>
+ CatalogV2Util.loadRelation(u.catalog, u.tableName)
.map(v2Relation => i.copy(table = v2Relation))
.getOrElse(i)
- case u: UnresolvedV2Relation =>
- CatalogV2Util.loadTable(u.catalog, u.tableName).map { table =>
- DataSourceV2Relation.create(table)
- }.getOrElse(u)
+ case desc @ DescribeTable(u: UnresolvedV2Relation, _) =>
+ CatalogV2Util.loadRelation(u.catalog, u.tableName)
+ .map(rel => desc.copy(table = rel))
+ .getOrElse(desc)
+
+ case alter @ AlterTable(_, _, u: UnresolvedV2Relation, _) =>
Review comment:
I tested out a trait that worked for all of the plans that need to be
resolved here, but the code was longer with the trait and implementations. If
we need it later because we have more cases in this rule, it should be easy to
add. I don't think we need it right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
