MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r336641864
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala
##########
@@ -256,12 +256,12 @@ object StreamingJoinHelper extends PredicateHelper with
Logging {
val castedLit = lit.dataType match {
case CalendarIntervalType =>
val calendarInterval = lit.value.asInstanceOf[CalendarInterval]
- if (calendarInterval.months > 0) {
+ if (calendarInterval.months > 0 || calendarInterval.days > 0) {
Review comment:
This can be breaking change. Why did you reject interval with days? By the
way, `days` can be converted to microseconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
